Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getStatusEffectBysource to lua_basenetity #6949

Conversation

jamesbradleym
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Adds getStatusEffectBySource to lua_basenetity.

Closes #6934

Steps to test these changes

  • !additem aiming_gloves
  • equip aiming gloves
  • use aiming gloves
  • see enhancement applied

@jamesbradleym jamesbradleym force-pushed the statuseffectbysource-baseentity branch 3 times, most recently from cd26b09 to 4c9a318 Compare February 4, 2025 21:35
@jamesbradleym jamesbradleym force-pushed the statuseffectbysource-baseentity branch from 4c9a318 to 0d66eb8 Compare February 4, 2025 21:43
Copy link
Contributor

@zach2good zach2good left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For passers-by, this already has an entry in the CBaseEntity spec:

---@nodiscard
---@param StatusID integer
---@param SourceType integer
---@param SourceTypeParam integer
---@return CStatusEffect?
function CBaseEntity:getStatusEffectBySource(StatusID, SourceType, SourceTypeParam)
end

@zach2good zach2good merged commit 1aee157 into LandSandBoat:base Feb 6, 2025
13 checks passed
@jamesbradleym jamesbradleym deleted the statuseffectbysource-baseentity branch February 6, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Useable items with getStatusEffectBySource not functioning
3 participants